Browse Source

Merge "fix(errata): workaround for Cortex-A78 erratum 2376745" into integration

pull/1985/head
Joanna Farley 3 years ago
committed by TrustedFirmware Code Review
parent
commit
3eb8cb4b54
  1. 4
      docs/design/cpu-specific-build-macros.rst
  2. 34
      lib/cpus/aarch64/cortex_a78.S
  3. 8
      lib/cpus/cpu-ops.mk

4
docs/design/cpu-specific-build-macros.rst

@ -296,6 +296,10 @@ For Cortex-A78, the following errata build flags are defined :
CPU. This needs to be enabled for revisions r1p0, r1p1, and r1p2. The issue
is present in r0p0 but there is no workaround. It is still open.
- ``ERRATA_A78_2376745``: This applies errata 2376745 workaround to Cortex-A78
CPU. This needs to be enabled for revisions r0p0, r1p0, r1p1, and r1p2, and
it is still open.
For Cortex-A78 AE, the following errata build flags are defined :
- ``ERRATA_A78_AE_1941500`` : This applies errata 1941500 workaround to

34
lib/cpus/aarch64/cortex_a78.S

@ -267,6 +267,34 @@ func check_errata_2242635
b cpu_rev_var_range
endfunc check_errata_2242635
/* --------------------------------------------------
* Errata Workaround for Cortex A78 Errata 2376745.
* This applies to revisions r0p0, r1p0, r1p1, and r1p2.
* It is still open.
* x0: variant[4:7] and revision[0:3] of current cpu.
* Shall clobber: x0-x1, x17
* --------------------------------------------------
*/
func errata_a78_2376745_wa
/* Check revision. */
mov x17, x30
bl check_errata_2376745
cbz x0, 1f
/* Apply the workaround. */
mrs x1, CORTEX_A78_ACTLR2_EL1
orr x1, x1, #BIT(0)
msr CORTEX_A78_ACTLR2_EL1, x1
1:
ret x17
endfunc errata_a78_2376745_wa
func check_errata_2376745
/* Applies to r0p0, r0p1, r1p1, and r1p2 */
mov x1, #CPU_REV(1, 2)
b cpu_rev_var_ls
endfunc check_errata_2376745
func check_errata_cve_2022_23960
#if WORKAROUND_CVE_2022_23960
mov x0, #ERRATA_APPLIES
@ -320,6 +348,11 @@ func cortex_a78_reset_func
bl errata_a78_2242635_wa
#endif
#if ERRATA_A78_2376745
mov x0, x18
bl errata_a78_2376745_wa
#endif
#if ENABLE_AMU
/* Make sure accesses from EL0/EL1 and EL2 are not trapped to EL3 */
mrs x0, actlr_el3
@ -390,6 +423,7 @@ func cortex_a78_errata_report
report_errata ERRATA_A78_1952683, cortex_a78, 1952683
report_errata ERRATA_A78_2132060, cortex_a78, 2132060
report_errata ERRATA_A78_2242635, cortex_a78, 2242635
report_errata ERRATA_A78_2376745, cortex_a78, 2376745
report_errata WORKAROUND_CVE_2022_23960, cortex_a78, cve_2022_23960
ldp x8, x30, [sp], #16

8
lib/cpus/cpu-ops.mk

@ -333,6 +333,10 @@ ERRATA_A78_2132060 ?=0
# present in r0p0 as well but there is no workaround for that revision.
ERRATA_A78_2242635 ?=0
# Flag to apply erratum 2376745 workaround during reset. This erratum applies
# to revisions r0p0, r1p0, r1p1, and r1p2 of the A78 cpu. It is still open.
ERRATA_A78_2376745 ?=0
# Flag to apply erratum 1941500 workaround during reset. This erratum applies
# to revisions r0p0 and r0p1 of the A78 AE cpu. It is still open.
ERRATA_A78_AE_1941500 ?=0
@ -842,6 +846,10 @@ $(eval $(call add_define,ERRATA_A78_2132060))
$(eval $(call assert_boolean,ERRATA_A78_2242635))
$(eval $(call add_define,ERRATA_A78_2242635))
# Process ERRATA_A78_2376745 flag
$(eval $(call assert_boolean,ERRATA_A78_2376745))
$(eval $(call add_define,ERRATA_A78_2376745))
# Process ERRATA_A78_AE_1941500 flag
$(eval $(call assert_boolean,ERRATA_A78_AE_1941500))
$(eval $(call add_define,ERRATA_A78_AE_1941500))

Loading…
Cancel
Save