From cf58b2d41cb0d24239b98de98264b31690711549 Mon Sep 17 00:00:00 2001 From: Boyan Karatotev Date: Tue, 25 Oct 2022 11:29:04 +0100 Subject: [PATCH] chore: rename Makalu ELP to Cortex-X3 The Cortex-X3 cpu port was developed before its public release when it was known as Makalu ELP. Now that it's released we can use the official product name. Signed-off-by: Boyan Karatotev Change-Id: Iebb90cf2f77330ed848a3d61c5f6928942189c5a --- docs/plat/arm/tc/index.rst | 2 +- .../security-advisory-tfv-9.rst | 4 +- .../{cortex_makalu_elp_arm.h => cortex_x3.h} | 18 +++--- lib/cpus/aarch64/cortex_x3.S | 58 +++++++++---------- 4 files changed, 41 insertions(+), 41 deletions(-) rename include/lib/cpus/aarch64/{cortex_makalu_elp_arm.h => cortex_x3.h} (54%) diff --git a/docs/plat/arm/tc/index.rst b/docs/plat/arm/tc/index.rst index ae2b83658..df1847d61 100644 --- a/docs/plat/arm/tc/index.rst +++ b/docs/plat/arm/tc/index.rst @@ -18,7 +18,7 @@ Currently, the main difference between TC0 (TARGET_PLATFORM=0), TC1 is the CPUs supported as below: - TC0 has support for Cortex A510, Cortex A710 and Cortex X2. -- TC1 has support for Cortex A510, Cortex Makalu and Cortex Makalu ELP. +- TC1 has support for Cortex A510, Cortex Makalu and Cortex X3. - TC2 has support for Hayes and Hunter Arm CPUs. diff --git a/docs/security_advisories/security-advisory-tfv-9.rst b/docs/security_advisories/security-advisory-tfv-9.rst index a4db17d24..08bfdc458 100644 --- a/docs/security_advisories/security-advisory-tfv-9.rst +++ b/docs/security_advisories/security-advisory-tfv-9.rst @@ -71,12 +71,12 @@ revisions of Cortex-A73 and Cortex-A75 that implements FEAT_CSV2). +----------------------+ | Cortex-X2 | +----------------------+ +| Cortex-X3 | ++----------------------+ | Cortex-A710 | +----------------------+ | Cortex-Makalu | +----------------------+ -| Cortex-Makalu-ELP | -+----------------------+ | Cortex-Hunter | +----------------------+ | Neoverse-N1 | diff --git a/include/lib/cpus/aarch64/cortex_makalu_elp_arm.h b/include/lib/cpus/aarch64/cortex_x3.h similarity index 54% rename from include/lib/cpus/aarch64/cortex_makalu_elp_arm.h rename to include/lib/cpus/aarch64/cortex_x3.h index 9ed5ee3c7..5fd07ff27 100644 --- a/include/lib/cpus/aarch64/cortex_makalu_elp_arm.h +++ b/include/lib/cpus/aarch64/cortex_x3.h @@ -4,23 +4,23 @@ * SPDX-License-Identifier: BSD-3-Clause */ -#ifndef CORTEX_MAKALU_ELP_ARM_H -#define CORTEX_MAKALU_ELP_ARM_H +#ifndef CORTEX_X3_H +#define CORTEX_X3_H -#define CORTEX_MAKALU_ELP_ARM_MIDR U(0x410FD4E0) +#define CORTEX_X3_MIDR U(0x410FD4E0) -/* Cortex Makalu ELP loop count for CVE-2022-23960 mitigation */ -#define CORTEX_MAKALU_ELP_ARM_BHB_LOOP_COUNT U(132) +/* Cortex-X3 loop count for CVE-2022-23960 mitigation */ +#define CORTEX_X3_BHB_LOOP_COUNT U(132) /******************************************************************************* * CPU Extended Control register specific definitions ******************************************************************************/ -#define CORTEX_MAKALU_ELP_ARM_CPUECTLR_EL1 S3_0_C15_C1_4 +#define CORTEX_X3_CPUECTLR_EL1 S3_0_C15_C1_4 /******************************************************************************* * CPU Power Control register specific definitions ******************************************************************************/ -#define CORTEX_MAKALU_ELP_ARM_CPUPWRCTLR_EL1 S3_0_C15_C2_7 -#define CORTEX_MAKALU_ELP_ARM_CPUPWRCTLR_EL1_CORE_PWRDN_BIT U(1) +#define CORTEX_X3_CPUPWRCTLR_EL1 S3_0_C15_C2_7 +#define CORTEX_X3_CPUPWRCTLR_EL1_CORE_PWRDN_BIT U(1) -#endif /* CORTEX_MAKALU_ELP_ARM_H */ +#endif /* CORTEX_X3_H */ diff --git a/lib/cpus/aarch64/cortex_x3.S b/lib/cpus/aarch64/cortex_x3.S index f4d2df09c..874d565c8 100644 --- a/lib/cpus/aarch64/cortex_x3.S +++ b/lib/cpus/aarch64/cortex_x3.S @@ -7,40 +7,40 @@ #include #include #include -#include +#include #include #include #include "wa_cve_2022_23960_bhb_vector.S" /* Hardware handled coherency */ #if HW_ASSISTED_COHERENCY == 0 -#error "Cortex Makalu ELP must be compiled with HW_ASSISTED_COHERENCY enabled" +#error "Cortex-X3 must be compiled with HW_ASSISTED_COHERENCY enabled" #endif /* 64-bit only core */ #if CTX_INCLUDE_AARCH32_REGS == 1 -#error "Cortex Makalu ELP supports only AArch64. Compile with CTX_INCLUDE_AARCH32_REGS=0" +#error "Cortex-X3 supports only AArch64. Compile with CTX_INCLUDE_AARCH32_REGS=0" #endif #if WORKAROUND_CVE_2022_23960 - wa_cve_2022_23960_bhb_vector_table CORTEX_MAKALU_ELP_ARM_BHB_LOOP_COUNT, cortex_makalu_elp_arm + wa_cve_2022_23960_bhb_vector_table CORTEX_X3_BHB_LOOP_COUNT, cortex_x3 #endif /* WORKAROUND_CVE_2022_23960 */ /* ---------------------------------------------------- * HW will do the cache maintenance while powering down * ---------------------------------------------------- */ -func cortex_makalu_elp_arm_core_pwr_dwn +func cortex_x3_core_pwr_dwn /* --------------------------------------------------- * Enable CPU power down bit in power control register * --------------------------------------------------- */ - mrs x0, CORTEX_MAKALU_ELP_ARM_CPUPWRCTLR_EL1 - orr x0, x0, #CORTEX_MAKALU_ELP_ARM_CPUPWRCTLR_EL1_CORE_PWRDN_BIT - msr CORTEX_MAKALU_ELP_ARM_CPUPWRCTLR_EL1, x0 + mrs x0, CORTEX_X3_CPUPWRCTLR_EL1 + orr x0, x0, #CORTEX_X3_CPUPWRCTLR_EL1_CORE_PWRDN_BIT + msr CORTEX_X3_CPUPWRCTLR_EL1, x0 isb ret -endfunc cortex_makalu_elp_arm_core_pwr_dwn +endfunc cortex_x3_core_pwr_dwn func check_errata_cve_2022_23960 #if WORKAROUND_CVE_2022_23960 @@ -51,28 +51,28 @@ func check_errata_cve_2022_23960 ret endfunc check_errata_cve_2022_23960 -func cortex_makalu_elp_arm_reset_func +func cortex_x3_reset_func /* Disable speculative loads */ msr SSBS, xzr #if IMAGE_BL31 && WORKAROUND_CVE_2022_23960 /* - * The Cortex Makalu ELP generic vectors are overridden to apply + * The Cortex-X3 generic vectors are overridden to apply * errata mitigation on exception entry from lower ELs. */ - adr x0, wa_cve_vbar_cortex_makalu_elp_arm + adr x0, wa_cve_vbar_cortex_x3 msr vbar_el3, x0 #endif /* IMAGE_BL31 && WORKAROUND_CVE_2022_23960 */ isb ret -endfunc cortex_makalu_elp_arm_reset_func +endfunc cortex_x3_reset_func #if REPORT_ERRATA -/* - * Errata printing function for Cortex Makalu ELP. Must follow AAPCS. - */ -func cortex_makalu_elp_arm_errata_report + /* + * Errata printing function for Cortex-X3. Must follow AAPCS. + */ +func cortex_x3_errata_report stp x8, x30, [sp, #-16]! bl cpu_get_rev_var @@ -82,15 +82,15 @@ func cortex_makalu_elp_arm_errata_report * Report all errata. The revision-variant information is passed to * checking functions of each errata. */ - report_errata WORKAROUND_CVE_2022_23960, cortex_makalu_elp_arm, cve_2022_23960 + report_errata WORKAROUND_CVE_2022_23960, cortex_x3, cve_2022_23960 ldp x8, x30, [sp], #16 ret -endfunc cortex_makalu_elp_arm_errata_report +endfunc cortex_x3_errata_report #endif /* --------------------------------------------- - * This function provides Cortex Makalu ELP- + * This function provides Cortex-X3- * specific register information for crash * reporting. It needs to return with x6 * pointing to a list of register names in ascii @@ -98,16 +98,16 @@ endfunc cortex_makalu_elp_arm_errata_report * reported. * --------------------------------------------- */ -.section .rodata.cortex_makalu_elp_arm_regs, "aS" -cortex_makalu_elp_arm_regs: /* The ascii list of register names to be reported */ +.section .rodata.cortex_x3_regs, "aS" +cortex_x3_regs: /* The ascii list of register names to be reported */ .asciz "cpuectlr_el1", "" -func cortex_makalu_elp_arm_cpu_reg_dump - adr x6, cortex_makalu_elp_arm_regs - mrs x8, CORTEX_MAKALU_ELP_ARM_CPUECTLR_EL1 +func cortex_x3_cpu_reg_dump + adr x6, cortex_x3_regs + mrs x8, CORTEX_X3_CPUECTLR_EL1 ret -endfunc cortex_makalu_elp_arm_cpu_reg_dump +endfunc cortex_x3_cpu_reg_dump -declare_cpu_ops cortex_makalu_elp_arm, CORTEX_MAKALU_ELP_ARM_MIDR, \ - cortex_makalu_elp_arm_reset_func, \ - cortex_makalu_elp_arm_core_pwr_dwn +declare_cpu_ops cortex_x3, CORTEX_X3_MIDR, \ + cortex_x3_reset_func, \ + cortex_x3_core_pwr_dwn