|
|
|
|
name: 'Install Rust toolchain'
|
|
|
|
|
description: 'Install a rust toolchain'
|
|
|
|
|
|
|
|
|
|
inputs:
|
|
|
|
|
toolchain:
|
|
|
|
|
description: 'Default toolchan to install'
|
|
|
|
|
required: false
|
|
|
|
|
default: 'default'
|
|
|
|
|
|
|
|
|
|
runs:
|
|
|
|
|
using: composite
|
|
|
|
|
steps:
|
|
|
|
|
- name: Install Rust
|
|
|
|
|
shell: bash
|
|
|
|
|
id: select
|
|
|
|
|
run: |
|
|
|
|
|
# Determine MSRV as N in `1.N.0` by looking at the `rust-version`
|
|
|
|
|
# located in the root `Cargo.toml`.
|
|
|
|
|
msrv=$(grep 'rust-version.*1' Cargo.toml | sed 's/.*\.\([0-9]*\)\..*/\1/')
|
|
|
|
|
|
|
|
|
|
if [ "${{ inputs.toolchain }}" = "default" ]; then
|
|
|
|
|
echo "version=1.$((msrv+2)).0" >> "$GITHUB_OUTPUT"
|
|
|
|
|
elif [ "${{ inputs.toolchain }}" = "msrv" ]; then
|
|
|
|
|
echo "version=1.$msrv.0" >> "$GITHUB_OUTPUT"
|
|
|
|
|
elif [ "${{ inputs.toolchain }}" = "wasmtime-ci-pinned-nightly" ]; then
|
|
|
|
|
echo "version=nightly-2024-07-25" >> "$GITHUB_OUTPUT"
|
|
|
|
|
else
|
|
|
|
|
echo "version=${{ inputs.toolchain }}" >> "$GITHUB_OUTPUT"
|
|
|
|
|
fi
|
|
|
|
|
|
|
|
|
|
- name: Install Rust
|
|
|
|
|
shell: bash
|
|
|
|
|
run: |
|
|
|
|
|
rustup set profile minimal
|
|
|
|
|
rustup update "${{ steps.select.outputs.version }}" --no-self-update
|
|
|
|
|
rustup default "${{ steps.select.outputs.version }}"
|
|
|
|
|
|
|
|
|
|
# Save disk space by avoiding incremental compilation. Also turn down
|
|
|
|
|
# debuginfo from 2 to 0 to help save disk space.
|
|
|
|
|
cat >> "$GITHUB_ENV" <<EOF
|
|
|
|
|
CARGO_INCREMENTAL=0
|
|
|
|
|
CARGO_PROFILE_DEV_DEBUG=0
|
|
|
|
|
CARGO_PROFILE_TEST_DEBUG=0
|
|
|
|
|
EOF
|
|
|
|
|
|
|
|
|
|
# Deny warnings on CI to keep our code warning-free as it lands in-tree.
|
|
|
|
|
echo RUSTFLAGS="-D warnings" >> "$GITHUB_ENV"
|
|
|
|
|
|
|
|
|
|
if [[ "${{ runner.os }}" = "macOS" ]]; then
|
|
|
|
|
cat >> "$GITHUB_ENV" <<EOF
|
|
|
|
|
CARGO_PROFILE_DEV_SPLIT_DEBUGINFO=unpacked
|
|
|
|
|
CARGO_PROFILE_TEST_SPLIT_DEBUGINFO=unpacked
|
|
|
|
|
EOF
|
|
|
|
|
fi
|
|
|
|
|
|
|
|
|
|
- name: Require semicolons in WIT
|
|
|
|
|
shell: bash
|
|
|
|
|
run: echo WIT_REQUIRE_SEMICOLONS=1 >> "$GITHUB_ENV"
|
|
|
|
|
|
Refactor the test-programs test suite (#7182)
* Refactor the test-programs test suite
This commit is a large refactoring that reorganizes `test-programs` and
how we tests wasms in Wasmtime. Often writing tests requires complicated
interactions with the guest which can't be done via hand-written `*.wat`
syntax and requires a compiler to get engaged. For this purpose Wasmtime
currently has the `crates/test-programs/*` test suite which builds files
from source and then runs the tests. This has been somewhat cumbersome
in the past though and it's not been easy to extend this over time, so
this commit attempts to address this.
The scheme implemented in this PR looks like:
* All wasm test programs live in `crates/test-programs/src/bin/*.rs`.
All of them, no exceptions.
* Wasm tests have shared support located at
`crates/test-programs/src/lib.rs` and its submodules, such as bindings
generation for WASI.
* Wasm tests are built by a new `crates/test-programs/artifacts` crate.
This crate compiles modules and additionally creates components for
all test programs. The crate itself only records the path to these
outputs and a small amount of testing support, but otherwise doesn't
interact with `wasmtime`-the-crate itself.
* All tests in `crates/test-programs/tests/*.rs` have moved. For example
wasi-http tests now live at `crates/wasi-http/tests/*.rs`. Legacy
tests of wasi-common now live at `crates/wasi-common/tests/*.rs`.
Modern tests for preview2 live at `crates/wasi/tests/*.rs`.
* Wasm tests are bucketed based on their filename prefix. For example
`preview1_*` is tested in wasi-common and wasmtime-wasi. The
`preview2_*` prefix is only tested with wasmtime-wasi, however.
* A new `cli_*` prefix is used to execute tests as part of
`tests/all/main.rs`. This is a new submodule in
`tests/all/cli_tests.rs` which executes these components on the
command line. Many old "command" tests were migrated here.
* Helper macros are generated to assert that a test suite is run in its
entirety. This way if a `preview1_*` test is added it's asserted to
get added to both wasi-common and wasmtime-wasi in the various modes
they run tests.
Overall this moved a number of tests around and refactored some edges of
the tests, but this should not lose any tests (except one that wasn't
actually testing anything). Additionally the hope is that it's much
easier to add tests in the future. The process is to add a new file in
`crates/test-programs/src/bin/*.rs` named appropriately. For example a
preview2 executable is `preview2_*` and a CLI tests is `cli_*`. When
building the test suite an error is generated in the appropriate module
then of "please write a test here", and then a test is written in the
same manner as the other tests in the module.
* Remove no-longer-needed fetches
prtest:full
* I'm worried wasi is running low on semicolons
* Add the WASI target in all CI actions
* Add unknown-unknown target on all CI builders too
* Fix building test artifacts under miri
Need to avoid wrappers for these cross-compiled targets
* Break circular dependency for packaging
Don't use the workspace dep for `wasmtime-wasi` since it injects a
version, instead use a `path = '..'` dependency to fool Cargo into
dropping the dependency during the package phase.
* Fix some merge conflicts with tests
* Fix rebase for new tests
* Remove stray comment
* Fix some flaky tests
* Fix network tests in synchronous mode
This commit is an attempt to fix some networking tests in synchronous
mode in our test suite. Currently networking tests don't actually run in
synchronous mode on CI which is why no failures have been surfaced yet,
but the refactoring in #7182 is going to start doing this.
Currently the `udp_sample_application.rs` test blocks infinitely in
synchronous mode for me locally, most of the time. This appears to be an
interaction between how Tokio handles readiness and how we're
entering the event loop. We're effectively entering the Tokio event loop
with a future that's always ready which ends up starving Tokio of
otherwise performing its background work such as updating flags for
readiness of reading/writing.
The fix here is to add a yield at the start of an `in_tokio` block which
is used in synchronous mode. This is a kludge fix but the intention is
to enable Tokio to have a chance to update readiness flags and process
events from epoll/kqueue/etc.
An additional fix to this issue is WebAssembly/wasi-sockets#64 where the
test is waiting on `READABLE` or `WRITABLE`, but in this specific case
it should only wait on `READABLE`. If it waited on just this then that
would also fix this issue. Nevertheless having a `yield_now` is expected
to have little-to-no overhead and otherwise fix this edge case of an
always-ready future.
* Fix passing empty arguments on the CLI
* Add another blocking accept
* Update crates/test-programs/src/bin/api_proxy.rs
Co-authored-by: Trevor Elliott <awesomelyawesome@gmail.com>
---------
Co-authored-by: Trevor Elliott <awesomelyawesome@gmail.com>
1 year ago
|
|
|
- name: Install the WASI target
|
|
|
|
|
shell: bash
|
|
|
|
|
run: rustup target add wasm32-wasip1 wasm32-unknown-unknown
|
