cranelift

13547 Commits

49 Branches

140 Tags

128 MiB

Branch: main

Commit Graph

Author	SHA1	Message	Date
Andrew Brown	c2fc362da2	mpk: enable MPK if available in CI (#7815 ) * mpk: enable MPK if available in CI After discussing several options for testing MPK in CI, this stopgap measure at least provides some coverage. Other options include maintaining a separate MPK-enabled CI runner (configuration is not transparent, hard to maintain) or running the MPK-enabled tests in a system-mode QEMU VM (tricky to get right, also hard to maintain). For now, those of us at the Cranelift meeting agreed this at least gets some CI testing for the MPK bits, which shouldn't be changing too often. Since not all GitHub runners have MPK available, we only set the `WASMTIME_TEST_FORCE_MPK` environment variable when it is. This change also emits a warning to the GitHub logs in either case for easier troubleshooting (e.g., to attempt to provide context if MPK logic breaks and is only found in a later CI run). prtest:full * review: create a separate matrix entry As requested by @alexcrichton, this change limits the MPK testing (and the associated warnings) to a new matrix target: `Test Linux x86_64 with MPK`.	9 months ago

Author

SHA1

Message

Date

Andrew Brown

c2fc362da2

mpk: enable MPK if available in CI (#7815 )

* mpk: enable MPK if available in CI

After discussing several options for testing MPK in CI, this stopgap
measure at least provides some coverage. Other options include
maintaining a separate MPK-enabled CI runner (configuration is not
transparent, hard to maintain) or running the MPK-enabled tests in a
system-mode QEMU VM (tricky to get right, also hard to maintain). For
now, those of us at the Cranelift meeting agreed this at least gets some
CI testing for the MPK bits, which shouldn't be changing too often.
Since not all GitHub runners have MPK available, we only set the
`WASMTIME_TEST_FORCE_MPK` environment variable when it is. This change
also emits a warning to the GitHub logs in either case for easier
troubleshooting (e.g., to attempt to provide context if MPK logic breaks
and is only found in a later CI run).

prtest:full

* review: create a separate matrix entry

As requested by @alexcrichton, this change limits the MPK testing (and
the associated warnings) to a new matrix target: `Test Linux x86_64 with
MPK`.

9 months ago

1 Commits (main)