cranelift

13471 Commits

49 Branches

140 Tags

128 MiB

Tree: 6907868078

Commit Graph

Author	SHA1	Message	Date
Alex Crichton	4896b6630d	Fix tail calls being turned on by default (#8682 ) * Fix tail calls being turned on by default Logic in `Config` to conditionally enable tail calls wasn't handling the case where the configured compiler strategy was `Strategy::Auto` meaning that by default tail calls weren't actually enabled. This commit refactors handling of `Strategy` to avoid storing `Strategy::Auto` in `CompilerConfig` so tests against it can use either cranelift or winch. * Update disas tests * Update Winch tests to using winch	6 months ago
Alex Crichton	ead7f735b4	Compile out wmemcheck-related libcalls when not enabled (#8203 ) Currently even when the `wmemcheck` Cargo feature is disabled the various related libcalls are still compiled into `wasmtime-runtime`. Additionally their signatures are translated when lowering functions, although the signatures are never used. This commit adds `#[cfg]` annotations to compile these all out when they're not enabled. Applying this change, however, uncovered a subtle bug in our libcalls. Libcalls are numbered in-order as-listed in the macro ignoring `#[cfg]`, but they're assigned a runtime slot in a `VMBuiltinFunctionsArray` structure which does respect `#[cfg]`. This meant, for example, that if `gc` was enabled and `wmemcheck` was disabled, as is the default for our tests, then there was a hole in the numbering where libcall numbers were mismatched at runtime and compile time. To fix this I've first added a const assertion that the runtime-number of libcalls equals the build-time number of libcalls. I then updated the macro a bit to plumb the `#[cfg]` differently and now libcalls are unconditionally defined regardless of cfgs but the implementation is `std::process::abort()` if it's compiled out. This ended up having a large-ish impact on the `disas` test suite. Lots of functions have fewer signatures translation because wmemcheck, even when disabled, was translating a few signatures. This also had some assembly changes, too, because I believe functions are considered leaves based on whether they declare a signature or not, so declaring an unused signature was preventing all wasm functions from being considered leaves.	8 months ago
Jamey Sharp	b0f13dc350	Turn most cranelift-wasm wasmtests into disas tests (#8144 ) * Turn most cranelift-wasm wasmtests into disas tests These tests mostly verify compiler behavior for specific WebAssembly constructs or small combinations. Currently they're only tested to make sure that cranelift-wasm doesn't crash or report an error. But they'd be even more useful if we track what CLIF we actually produce from Wasmtime. So I'm moving them to the new disas test framework and adding basic CLIF test expectations for them. I've excluded the .wat files which were produced by Emscripten or Rust, because they're very large and their compiled CLIF is not very interesting to look at. * Add test expectations	8 months ago

Author

SHA1

Message

Date

Alex Crichton

4896b6630d

Fix tail calls being turned on by default (#8682 )

* Fix tail calls being turned on by default

Logic in `Config` to conditionally enable tail calls wasn't handling the
case where the configured compiler strategy was `Strategy::Auto` meaning
that by default tail calls weren't actually enabled. This commit
refactors handling of `Strategy` to avoid storing `Strategy::Auto` in
`CompilerConfig` so tests against it can use either cranelift or winch.

* Update disas tests

* Update Winch tests to using winch

6 months ago

Alex Crichton

ead7f735b4

Compile out wmemcheck-related libcalls when not enabled (#8203 )

Currently even when the `wmemcheck` Cargo feature is disabled the
various related libcalls are still compiled into `wasmtime-runtime`.
Additionally their signatures are translated when lowering functions,
although the signatures are never used. This commit adds `#[cfg]`
annotations to compile these all out when they're not enabled.

Applying this change, however, uncovered a subtle bug in our libcalls.
Libcalls are numbered in-order as-listed in the macro ignoring `#[cfg]`,
but they're assigned a runtime slot in a `VMBuiltinFunctionsArray`
structure which does respect `#[cfg]`. This meant, for example, that if
`gc` was enabled and `wmemcheck` was disabled, as is the default for our
tests, then there was a hole in the numbering where libcall numbers were
mismatched at runtime and compile time.

To fix this I've first added a const assertion that the runtime-number
of libcalls equals the build-time number of libcalls. I then updated the
macro a bit to plumb the `#[cfg]` differently and now libcalls are
unconditionally defined regardless of cfgs but the implementation is
`std::process::abort()` if it's compiled out.

This ended up having a large-ish impact on the `disas` test suite. Lots
of functions have fewer signatures translation because wmemcheck, even
when disabled, was translating a few signatures. This also had some
assembly changes, too, because I believe functions are considered leaves
based on whether they declare a signature or not, so declaring an unused
signature was preventing all wasm functions from being considered leaves.

8 months ago

Jamey Sharp

b0f13dc350

Turn most cranelift-wasm wasmtests into disas tests (#8144 )

* Turn most cranelift-wasm wasmtests into disas tests

These tests mostly verify compiler behavior for specific WebAssembly
constructs or small combinations.

Currently they're only tested to make sure that cranelift-wasm doesn't
crash or report an error. But they'd be even more useful if we track
what CLIF we actually produce from Wasmtime.

So I'm moving them to the new disas test framework and adding basic CLIF
test expectations for them.

I've excluded the .wat files which were produced by Emscripten or Rust,
because they're very large and their compiled CLIF is not very
interesting to look at.

* Add test expectations

8 months ago

3 Commits (69078680785df7330dd967d00f8d82cf590b5179)