From 2b73af424935a5102589517933ecf499d17238c2 Mon Sep 17 00:00:00 2001
From: Sami Vaarala <sami.vaarala@iki.fi>
Date: Thu, 20 Nov 2014 19:39:51 +0200
Subject: [PATCH] Testcases for JSON.parse() syntax error offset

---
 api-testcases/test-json.c                     | 27 +++++++++++++--
 .../test-bi-json-dec-error-offset.js          | 34 +++++++++++++++++++
 2 files changed, 59 insertions(+), 2 deletions(-)
 create mode 100644 ecmascript-testcases/test-bi-json-dec-error-offset.js

diff --git a/api-testcases/test-json.c b/api-testcases/test-json.c
index 9e168d9b..f93ab572 100644
--- a/api-testcases/test-json.c
+++ b/api-testcases/test-json.c
@@ -16,7 +16,10 @@ JSON decoded meaningOfLife is: 42
 top after: 0
 ==> rc=0, result='undefined'
 *** test_decode_error (duk_safe_call)
-==> rc=1, result='SyntaxError: invalid json'
+ret: 1
+SyntaxError: invalid json (at offset N)
+top after: 0
+==> rc=0, result='undefined'
 ===*/
 
 static duk_ret_t test_encode(duk_context *ctx) {
@@ -65,9 +68,29 @@ static duk_ret_t test_decode_apidoc(duk_context *ctx) {
 	return 0;
 }
 
+static duk_ret_t test_decode_error_raw(duk_context *ctx) {
+	duk_json_decode(ctx, -1);
+	return 1;
+}
+
 static duk_ret_t test_decode_error(duk_context *ctx) {
+	/* The JSON.parse() error message includes a byte offset, so we need to
+	 * normalize it.
+	 */
+	duk_int_t ret;
+
 	duk_push_string(ctx, "{\"meaningOfLife\":,42}");
-	duk_json_decode(ctx, -1);
+	ret = duk_safe_call(ctx, test_decode_error_raw, 1 /*nargs*/, 1 /*nrets*/);
+	printf("ret: %ld\n", (long) ret);
+
+	duk_eval_string(ctx, "(function (x) { print(x.replace(/at offset \\d+/, 'at offset N')); })");
+	duk_dup(ctx, -2);
+	duk_to_string(ctx, -1);
+	duk_call(ctx, 1 /*nargs*/);
+
+	duk_pop(ctx);  /* duk_call result */
+	duk_pop(ctx);  /* duk_safe_call result */
+
 	printf("top after: %ld\n", (long) duk_get_top(ctx));
 	duk_set_top(ctx, 0);
 	return 0;
diff --git a/ecmascript-testcases/test-bi-json-dec-error-offset.js b/ecmascript-testcases/test-bi-json-dec-error-offset.js
new file mode 100644
index 00000000..4f3c0cfd
--- /dev/null
+++ b/ecmascript-testcases/test-bi-json-dec-error-offset.js
@@ -0,0 +1,34 @@
+/*
+ *  Test JSON error byte offset
+ */
+
+/*---
+{
+    "custom": true
+}
+---*/
+
+/*===
+SyntaxError: invalid json (at offset 11)
+SyntaxError: invalid json (at offset 17)
+===*/
+
+function test1() {
+    JSON.parse('[ "\ufedcfoo"; ]');  // error at char offset 8, byte offset, 11
+}
+
+function test2() {
+    JSON.parse('{ "foo": "bar" } x');  // error at byte offset 17
+}
+
+try {
+    test1();
+} catch (e) {
+    print(e);
+}
+
+try {
+    test2();
+} catch (e) {
+    print(e);
+}