Merge pull request #1439 from svaarala/runtests-apitest-no-werror

Remove -Werror from runtests.js (apitest)

Makefile

@@ -542,7 +542,7 @@ checkalign:
 
 # Overall test target, not very useful.
 .PHONY: test
-test: qecmatest apitest regfuzztest underscoretest lodashtest emscriptentest emscripteninceptiontest test262test
+test: qecmatest apitest regfuzztest underscoretest lodashtest emscriptentest test262test
 
 # Runtests-based Ecmascript and API tests.
 .PHONY:	runtestsdeps
@@ -650,7 +650,7 @@ emscriptenmandeltest: emscripten duk
 # Duktape.
 .PHONY: emscripteninceptiontest
 emscripteninceptiontest: emscripten prep/nondebug duk
-	@echo "### emscripteniceptiontest"
+	@echo "### emscripteninceptiontest"
 	@rm -f /tmp/duk-emcc-test*
 	@echo "NOTE: this emscripten test is incomplete (compiles Duktape and hello.c and runs it, no checks yet)"
 	emscripten/emcc $(EMCCOPTS) -Iprep/nondebug prep/nondebug/duktape.c examples/hello/hello.c -o /tmp/duk-emcc-test.js

doc/release-checklist.rst

@@ -160,6 +160,9 @@ Checklist for ordinary releases
 
     - make apitest
 
+    - -Werror is no longer enabled so check apitest output for any test
+      case warnings (or enable -Werror manually in runtests.js)
+
 * Regfuzz
 
   - On x86-64, with DUK_USE_ASSERTIONS

runtests/runtests.js

@@ -271,7 +271,7 @@ function executeTest(options, callback) {
                 '-Wl,-rpath,.',
                 '-pedantic', '-ansi', '-std=c99', '-Wall', '-Wdeclaration-after-statement', '-fstrict-aliasing', '-D__POSIX_C_SOURCE=200809L', '-D_GNU_SOURCE', '-D_XOPEN_SOURCE', '-Os', '-fomit-frame-pointer',
                 '-g', '-ggdb',
-                '-Werror',
+                //'-Werror',  // Would be nice but GCC differences break tests too easily
                 //'-m32',
                 'runtests/api_testcase_main.c',
                 tempSource,