Browse Source

fixme notes for currently missing features

pull/2/head
Sami Vaarala 11 years ago
parent
commit
5bb69ec733
  1. 10
      src/duk_heap_alloc.c
  2. 2
      src/duk_heap_refcount.c

10
src/duk_heap_alloc.c

@ -40,7 +40,15 @@ static void duk__free_hobject_inner(duk_heap *heap, duk_hobject *h) {
DUK_FREE(heap, t->valstack);
DUK_FREE(heap, t->callstack);
DUK_FREE(heap, t->catchstack);
/* don't free h->resumer, because it exists in the heap */
/* Don't free h->resumer, because it exists in the heap.
* Callstack entries also contain function pointers which
* are not freed for the same reason.
*/
/* FIXME: with 'caller' property the callstack would need
* to be unwound to update the 'caller' properties of
* functions in the callstack.
*/
}
}

2
src/duk_heap_refcount.c

@ -127,8 +127,6 @@ static void duk__refcount_finalize_hobject(duk_hthread *thr, duk_hobject *h) {
#endif
}
/* FIXME: restoring 'func' values */
#if 0 /* nothing now */
for (i = 0; i < t->catchstack_top; i++) {
duk_catcher *cat = &t->catchstack[i];

Loading…
Cancel
Save