Browse Source

remove FIXME as incorrect: the result of array transformations is an array even if 'this' is not one, so 'length' must always be set

pull/1/head
Sami Vaarala 11 years ago
parent
commit
75cf56e9a5
  1. 4
      src/duk_bi_array.c

4
src/duk_bi_array.c

@ -192,10 +192,6 @@ int duk_bi_array_prototype_concat(duk_context *ctx) {
duk_pop(ctx);
}
/* FIXME: this is only correct for Array objects, not when 'this' is something
* else. It would be easiest if the duk_def_prop_index() had a variant which
* obeyed array special 'length' behavior.
*/
duk_push_number(ctx, (double) idx_last);
duk_def_prop_stridx(ctx, -2, DUK_STRIDX_LENGTH, DUK_PROPDESC_FLAGS_WC);

Loading…
Cancel
Save