Browse Source

fixme cleanups

pull/2/head
Sami Vaarala 11 years ago
parent
commit
80fd4fe13e
  1. 5
      src/duk_api_internal.h
  2. 4
      src/duk_heap.h
  3. 4
      src/duk_js_compiler.h

5
src/duk_api_internal.h

@ -22,11 +22,8 @@ int duk_check_stack_raw(duk_context *ctx, unsigned int extra);
void duk_require_stack_raw(duk_context *ctx, unsigned int extra);
duk_tval *duk_get_tval(duk_context *ctx, int index);
duk_tval duk_get_tval_value(duk_context *ctx, int index); /* FIXME: not implemented now */
duk_tval *duk_require_tval(duk_context *ctx, int index);
duk_tval duk_require_tval_value(duk_context *ctx, int index); /* FIXME: not implemented now */
void duk_push_tval(duk_context *ctx, duk_tval *tv);
void duk_push_tval_value(duk_context *ctx, duk_tval tv); /* FIXME: not implemented now */
void duk_push_this_check_object_coercible(duk_context *ctx); /* push the current 'this' binding; throw TypeError
* if binding is not object coercible (CheckObjectCoercible).
@ -44,7 +41,7 @@ duk_hthread *duk_get_hthread(duk_context *ctx, int index);
duk_hcompiledfunction *duk_get_hcompiledfunction(duk_context *ctx, int index);
duk_hnativefunction *duk_get_hnativefunction(duk_context *ctx, int index);
/* FIXME: specific getters for e.g. thread; duk_get_hobject_with_flags()
/* XXX: add specific getters for e.g. thread; duk_get_hobject_with_flags()
* could be the underlying primitive?
*/

4
src/duk_heap.h

@ -200,8 +200,8 @@
/*
* Memory calls: relative to heap, GC interaction, but no error throwing.
*
* FIXME: currently a mark-and-sweep triggered by memory allocation will
* run using the heap->heap_thread. This thread is also used for running
* TODO: Currently a mark-and-sweep triggered by memory allocation will run
* using the heap->heap_thread. This thread is also used for running
* mark-and-sweep finalization; this is not ideal because it breaks the
* isolation between multiple global environments.
*

4
src/duk_js_compiler.h

@ -77,10 +77,6 @@ struct duk_compiler_instr {
* Compiler state
*/
/* FIXME: these two defines are not referenced? */
#define DUK_MAX_MAPPED_REGS 128 /* max regs mapped to arguments and variables */
#define DUK_MAX_ACTIVE_LABELS 64
#define DUK_LABEL_FLAG_ALLOW_BREAK (1 << 0)
#define DUK_LABEL_FLAG_ALLOW_CONTINUE (1 << 1)

Loading…
Cancel
Save