duktape

8566 Commits

65 Branches

60 Tags

84 MiB

Tree: 9c42b8cb36

Commit Graph

Author	SHA1	Message	Date
Sami Vaarala	c6f9ee1550	Fix Symbol object .valueOf()	8 years ago
Sami Vaarala	a08c85753e	Make symbol checks unlikely Usually symbol checks are in code paths expecting a string; make these unlikely. For code paths where a symbol is expected, make the check likely.	8 years ago
Sami Vaarala	5ed6bb980b	Add initial, minimal ES6 Symbol support * Strings with 0xFF byte prefix are considered special symbols: they have typeof "symbol" but still mostly behave as strings (e.g. allow ToString) so that existing code dealing with internal keys, especially inside Duktape, can work with fewer changes. * Strings with 0x80 byte prefix are global symbols, e.g. Symbol.for('foo') creates the byte representatio: 0x80 "foo" * Strings with 0x81 byte prefix are unique symbols; the 0x81 byte is followed by the Symbol description, and an internal string component ensuring uniqueness is separated by a 0xFF byte (which can never appear anywhere in an extended UTF-8 string). The unique suffix is up to Duktape internals, currently two 32-bit counters are used. For example: 0x81 "mySymbol" 0xFF "0-17". * Well-known symbols use the 0x81 prefix but lack a unique suffix, so their format is 0x81 <description> 0xFF. * ES6 distinguishes between an undefined symbol description and an empty string symbol description. This distinction is not currently visible via Ecmascript bindings but may be visible in the future. Append an extra 0xFF to the unique suffix when the description is undefined, i.e. 0x81 0xFF <unique suffix> 0xFF.	8 years ago

Author

SHA1

Message

Date

Sami Vaarala

c6f9ee1550

Fix Symbol object .valueOf()

8 years ago

Sami Vaarala

a08c85753e

Make symbol checks unlikely

Usually symbol checks are in code paths expecting a string; make these
unlikely.  For code paths where a symbol is expected, make the check
likely.

8 years ago

Sami Vaarala

5ed6bb980b

Add initial, minimal ES6 Symbol support

* Strings with 0xFF byte prefix are considered special symbols: they have
  typeof "symbol" but still mostly behave as strings (e.g. allow ToString)
  so that existing code dealing with internal keys, especially inside
  Duktape, can work with fewer changes.

* Strings with 0x80 byte prefix are global symbols, e.g. Symbol.for('foo')
  creates the byte representatio: 0x80 "foo"

* Strings with 0x81 byte prefix are unique symbols; the 0x81 byte is followed
  by the Symbol description, and an internal string component ensuring
  uniqueness is separated by a 0xFF byte (which can never appear anywhere in
  an extended UTF-8 string).  The unique suffix is up to Duktape internals,
  currently two 32-bit counters are used.  For example:
  0x81 "mySymbol" 0xFF "0-17".

* Well-known symbols use the 0x81 prefix but lack a unique suffix, so their
  format is 0x81 <description> 0xFF.

* ES6 distinguishes between an undefined symbol description and an empty
  string symbol description.  This distinction is not currently visible via
  Ecmascript bindings but may be visible in the future.  Append an extra
  0xFF to the unique suffix when the description is undefined, i.e.
  0x81 0xFF <unique suffix> 0xFF.

8 years ago

3 Commits (9c42b8cb367ba8b16c200375bc1cc95bf144e165)