From 26eb002270396d91271e4a033fa823110e8d26e0 Mon Sep 17 00:00:00 2001 From: Emil Ernerfeldt Date: Mon, 12 Dec 2022 21:45:57 +0100 Subject: [PATCH] Remove references to old, fixed Firefox WebGL bug --- crates/eframe/README.md | 1 - crates/eframe/src/epi.rs | 3 --- 2 files changed, 4 deletions(-) diff --git a/crates/eframe/README.md b/crates/eframe/README.md index 609b3571c..dfcfa6ef5 100644 --- a/crates/eframe/README.md +++ b/crates/eframe/README.md @@ -45,7 +45,6 @@ You can also use `egui_glow` and [`winit`](https://github.com/rust-windowing/win * Mobile text editing is not as good as for a normal web app. * Accessibility: There is an experimental screen reader for `eframe`, but it has to be enabled explicitly. There is no JS function to ask "Does the user want a screen reader?" (and there should probably not be such a function, due to user tracking/integrity concerns). * No integration with browser settings for colors and fonts. -* On Linux and Mac, Firefox will copy the WebGL render target from GPU, to CPU and then back again (https://bugzilla.mozilla.org/show_bug.cgi?id=1010527#c0), slowing down egui. In many ways, `eframe` is trying to make the browser do something it wasn't designed to do (though there are many things browser vendors could do to improve how well libraries like egui work). diff --git a/crates/eframe/src/epi.rs b/crates/eframe/src/epi.rs index 228a005de..62c1d2f2e 100644 --- a/crates/eframe/src/epi.rs +++ b/crates/eframe/src/epi.rs @@ -145,9 +145,6 @@ pub trait App { /// The size limit of the web app canvas. /// /// By default the max size is [`egui::Vec2::INFINITY`], i.e. unlimited. - /// - /// A large canvas can lead to bad frame rates on some older browsers on some platforms - /// (see ). fn max_size_points(&self) -> egui::Vec2 { egui::Vec2::INFINITY }