diff --git a/crates/egui_glow/src/painter.rs b/crates/egui_glow/src/painter.rs index db2ff76d7..f8f6145c8 100644 --- a/crates/egui_glow/src/painter.rs +++ b/crates/egui_glow/src/painter.rs @@ -22,14 +22,18 @@ const VERT_SRC: &str = include_str!("shader/vertex.glsl"); const FRAG_SRC: &str = include_str!("shader/fragment.glsl"); trait TextureFilterExt { - fn glow_code(&self) -> u32; + fn glow_code(&self, mipmap: Option) -> u32; } impl TextureFilterExt for egui::TextureFilter { - fn glow_code(&self) -> u32 { - match self { - Self::Linear => glow::LINEAR, - Self::Nearest => glow::NEAREST, + fn glow_code(&self, mipmap: Option) -> u32 { + match (self, mipmap) { + (Self::Linear, None) => glow::LINEAR, + (Self::Nearest, None) => glow::NEAREST, + (Self::Linear, Some(Self::Linear)) => glow::LINEAR_MIPMAP_LINEAR, + (Self::Nearest, Some(Self::Linear)) => glow::NEAREST_MIPMAP_LINEAR, + (Self::Linear, Some(Self::Nearest)) => glow::LINEAR_MIPMAP_NEAREST, + (Self::Nearest, Some(Self::Nearest)) => glow::NEAREST_MIPMAP_NEAREST, } } } @@ -569,12 +573,12 @@ impl Painter { self.gl.tex_parameter_i32( glow::TEXTURE_2D, glow::TEXTURE_MAG_FILTER, - options.magnification.glow_code() as i32, + options.magnification.glow_code(None) as i32, ); self.gl.tex_parameter_i32( glow::TEXTURE_2D, glow::TEXTURE_MIN_FILTER, - options.minification.glow_code() as i32, + options.minification.glow_code(options.mipmap_mode) as i32, ); self.gl.tex_parameter_i32( @@ -635,6 +639,11 @@ impl Painter { ); check_for_gl_error!(&self.gl, "tex_image_2d"); } + + if options.mipmap_mode.is_some() { + self.gl.generate_mipmap(glow::TEXTURE_2D); + check_for_gl_error!(&self.gl, "generate_mipmap"); + } } } diff --git a/crates/epaint/src/textures.rs b/crates/epaint/src/textures.rs index 4244c6871..cc191a75f 100644 --- a/crates/epaint/src/textures.rs +++ b/crates/epaint/src/textures.rs @@ -159,6 +159,16 @@ pub struct TextureOptions { /// How to wrap the texture when the texture coordinates are outside the [0, 1] range. pub wrap_mode: TextureWrapMode, + + /// How to filter between texture mipmaps. + /// + /// Mipmaps ensures textures look smooth even when the texture is very small and pixels are much + /// larger than individual texels. + /// + /// # Notes + /// + /// - This may not be available on all backends (currently only `egui_glow`). + pub mipmap_mode: Option, } impl TextureOptions { @@ -167,6 +177,7 @@ impl TextureOptions { magnification: TextureFilter::Linear, minification: TextureFilter::Linear, wrap_mode: TextureWrapMode::ClampToEdge, + mipmap_mode: None, }; /// Nearest magnification and minification. @@ -174,6 +185,7 @@ impl TextureOptions { magnification: TextureFilter::Nearest, minification: TextureFilter::Nearest, wrap_mode: TextureWrapMode::ClampToEdge, + mipmap_mode: None, }; /// Linear magnification and minification, but with the texture repeated. @@ -181,6 +193,7 @@ impl TextureOptions { magnification: TextureFilter::Linear, minification: TextureFilter::Linear, wrap_mode: TextureWrapMode::Repeat, + mipmap_mode: None, }; /// Linear magnification and minification, but with the texture mirrored and repeated. @@ -188,6 +201,7 @@ impl TextureOptions { magnification: TextureFilter::Linear, minification: TextureFilter::Linear, wrap_mode: TextureWrapMode::MirroredRepeat, + mipmap_mode: None, }; /// Nearest magnification and minification, but with the texture repeated. @@ -195,6 +209,7 @@ impl TextureOptions { magnification: TextureFilter::Nearest, minification: TextureFilter::Nearest, wrap_mode: TextureWrapMode::Repeat, + mipmap_mode: None, }; /// Nearest magnification and minification, but with the texture mirrored and repeated. @@ -202,7 +217,15 @@ impl TextureOptions { magnification: TextureFilter::Nearest, minification: TextureFilter::Nearest, wrap_mode: TextureWrapMode::MirroredRepeat, + mipmap_mode: None, }; + + pub const fn with_mipmap_mode(self, mipmap_mode: Option) -> Self { + Self { + mipmap_mode, + ..self + } + } } impl Default for TextureOptions {