Browse Source

rename metrics to adhere to naming conventions

pull/1424/head
Marten Seemann 4 years ago
parent
commit
84acfa12b6
  1. 18
      p2p/transport/quic/tracer_metrics.go

18
p2p/transport/quic/tracer_metrics.go

@ -88,7 +88,7 @@ func init() {
closedConns = prometheus.NewCounterVec( closedConns = prometheus.NewCounterVec(
prometheus.CounterOpts{ prometheus.CounterOpts{
Name: "quic_closed_connections", Name: "quic_connections_closed_total",
Help: "closed QUIC connection", Help: "closed QUIC connection",
}, },
[]string{direction}, []string{direction},
@ -96,7 +96,7 @@ func init() {
prometheus.MustRegister(closedConns) prometheus.MustRegister(closedConns)
newConns = prometheus.NewCounterVec( newConns = prometheus.NewCounterVec(
prometheus.CounterOpts{ prometheus.CounterOpts{
Name: "quic_new_connections", Name: "quic_connections_new_total",
Help: "new QUIC connection", Help: "new QUIC connection",
}, },
[]string{direction, "handshake_successful"}, []string{direction, "handshake_successful"},
@ -104,7 +104,7 @@ func init() {
prometheus.MustRegister(newConns) prometheus.MustRegister(newConns)
bytesTransferred = prometheus.NewCounterVec( bytesTransferred = prometheus.NewCounterVec(
prometheus.CounterOpts{ prometheus.CounterOpts{
Name: "quic_bytes_transferred", Name: "quic_transferred_bytes",
Help: "QUIC bytes transferred", Help: "QUIC bytes transferred",
}, },
[]string{direction}, // TODO: this is confusing. Other times, we use direction for the perspective []string{direction}, // TODO: this is confusing. Other times, we use direction for the perspective
@ -112,7 +112,7 @@ func init() {
prometheus.MustRegister(bytesTransferred) prometheus.MustRegister(bytesTransferred)
sentPackets = prometheus.NewCounterVec( sentPackets = prometheus.NewCounterVec(
prometheus.CounterOpts{ prometheus.CounterOpts{
Name: "quic_sent_packets", Name: "quic_packets_sent_total",
Help: "QUIC packets sent", Help: "QUIC packets sent",
}, },
[]string{encLevel}, []string{encLevel},
@ -120,7 +120,7 @@ func init() {
prometheus.MustRegister(sentPackets) prometheus.MustRegister(sentPackets)
rcvdPackets = prometheus.NewCounterVec( rcvdPackets = prometheus.NewCounterVec(
prometheus.CounterOpts{ prometheus.CounterOpts{
Name: "quic_rcvd_packets", Name: "quic_packets_rcvd_total",
Help: "QUIC packets received", Help: "QUIC packets received",
}, },
[]string{encLevel}, []string{encLevel},
@ -128,7 +128,7 @@ func init() {
prometheus.MustRegister(rcvdPackets) prometheus.MustRegister(rcvdPackets)
bufferedPackets = prometheus.NewCounterVec( bufferedPackets = prometheus.NewCounterVec(
prometheus.CounterOpts{ prometheus.CounterOpts{
Name: "quic_buffered_packets", Name: "quic_packets_buffered_total",
Help: "Buffered packets", Help: "Buffered packets",
}, },
[]string{"packet_type"}, []string{"packet_type"},
@ -136,7 +136,7 @@ func init() {
prometheus.MustRegister(bufferedPackets) prometheus.MustRegister(bufferedPackets)
droppedPackets = prometheus.NewCounterVec( droppedPackets = prometheus.NewCounterVec(
prometheus.CounterOpts{ prometheus.CounterOpts{
Name: "quic_dropped_packets", Name: "quic_packets_dropped_total",
Help: "Dropped packets", Help: "Dropped packets",
}, },
[]string{"packet_type", "reason"}, []string{"packet_type", "reason"},
@ -144,7 +144,7 @@ func init() {
prometheus.MustRegister(droppedPackets) prometheus.MustRegister(droppedPackets)
connErrors = prometheus.NewCounterVec( connErrors = prometheus.NewCounterVec(
prometheus.CounterOpts{ prometheus.CounterOpts{
Name: "quic_conn_errors", Name: "quic_connection_errors_total",
Help: "QUIC connection errors", Help: "QUIC connection errors",
}, },
[]string{"side", "error_code"}, []string{"side", "error_code"},
@ -152,7 +152,7 @@ func init() {
prometheus.MustRegister(connErrors) prometheus.MustRegister(connErrors)
lostPackets = prometheus.NewCounterVec( lostPackets = prometheus.NewCounterVec(
prometheus.CounterOpts{ prometheus.CounterOpts{
Name: "quic_lost_packets", Name: "quic_packets_lost_total",
Help: "QUIC lost received", Help: "QUIC lost received",
}, },
[]string{encLevel, "reason"}, []string{encLevel, "reason"},

Loading…
Cancel
Save