From 9cb3cd114920a901cb2afb8b5dc9b4d6bd25f67b Mon Sep 17 00:00:00 2001 From: Marten Seemann Date: Wed, 18 May 2022 21:11:39 +0200 Subject: [PATCH] tls: fix flaky handshake cancelation test (#1503) --- p2p/security/tls/transport_test.go | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/p2p/security/tls/transport_test.go b/p2p/security/tls/transport_test.go index a290ed6fd..b6d490301 100644 --- a/p2p/security/tls/transport_test.go +++ b/p2p/security/tls/transport_test.go @@ -165,7 +165,13 @@ func TestHandshakeConnectionCancelations(t *testing.T) { go func() { ctx, cancel := context.WithCancel(context.Background()) cancel() - _, err := serverTransport.SecureInbound(ctx, &delayedConn{Conn: serverInsecureConn, delay: 5 * time.Millisecond}, "") + conn, err := serverTransport.SecureInbound(ctx, &delayedConn{Conn: serverInsecureConn, delay: 5 * time.Millisecond}, "") + // crypto/tls' context handling works by spinning up a separate Go routine that watches the context, + // and closes the underlying connection when that context is canceled. + // It is therefore not guaranteed (but very likely) that this happens _during_ the TLS handshake. + if err == nil { + _, err = conn.Read([]byte{0}) + } errChan <- err }() _, err = clientTransport.SecureOutbound(context.Background(), clientInsecureConn, serverID) @@ -188,7 +194,13 @@ func TestPeerIDMismatch(t *testing.T) { errChan := make(chan error) go func() { - _, err := serverTransport.SecureInbound(context.Background(), serverInsecureConn, "") + conn, err := serverTransport.SecureInbound(context.Background(), serverInsecureConn, "") + // crypto/tls' context handling works by spinning up a separate Go routine that watches the context, + // and closes the underlying connection when that context is canceled. + // It is therefore not guaranteed (but very likely) that this happens _during_ the TLS handshake. + if err == nil { + _, err = conn.Read([]byte{0}) + } errChan <- err }()