Browse Source

Clipper: Amend ecb0aaa (#6424, #3841)

pull/6441/head
GamingMinds-DanielC 2 years ago
committed by ocornut
parent
commit
e489e40a85
  1. 4
      docs/CHANGELOG.txt
  2. 8
      imgui.cpp
  3. 1
      imgui_internal.h

4
docs/CHANGELOG.txt

@ -38,9 +38,9 @@ HOW TO UPDATE?
Breaking changes:
- Clipper: Commented out obsolete redirection constructor which was marked obsolete in 1.79:
'ImGuiListClipper(int items_count, float items_height)' --> Use 'ImGuiListClipper() + clipper.Begin().clipper.Begin()'.
'ImGuiListClipper(int items_count, float items_height)' --> Use 'ImGuiListClipper() + clipper.Begin()'.
- Clipper: Renamed ForceDisplayRangeByIndices() to IncludeRangeByIndices(), kept
inline redirection function (introduced in 1.86 andrarely used). (#6424, #3841)
inline redirection function (introduced in 1.86 and rarely used). (#6424, #3841)
- Backends: GLUT: Removed call to ImGui::NewFrame() from ImGui_ImplGLUT_NewFrame().
It needs to be called from the main app loop, like with every other backends. (#6337) [@GereonV]

8
imgui.cpp

@ -2806,13 +2806,13 @@ void ImGuiListClipper::End()
ItemsCount = -1;
}
void ImGuiListClipper::IncludeRangeByIndices(int item_min, int item_max)
void ImGuiListClipper::IncludeRangeByIndices(int item_begin, int item_end)
{
ImGuiListClipperData* data = (ImGuiListClipperData*)TempData;
IM_ASSERT(DisplayStart < 0); // Only allowed after Begin() and if there has not been a specified range yet.
IM_ASSERT(item_min <= item_max);
if (item_min < item_max)
data->Ranges.push_back(ImGuiListClipperRange::FromIndices(item_min, item_max));
IM_ASSERT(item_begin <= item_end);
if (item_begin < item_end)
data->Ranges.push_back(ImGuiListClipperRange::FromIndices(item_begin, item_end));
}
static bool ImGuiListClipper_StepInternal(ImGuiListClipper* clipper)

1
imgui_internal.h

@ -1404,6 +1404,7 @@ enum ImGuiInputFlags_
// [SECTION] Clipper support
//-----------------------------------------------------------------------------
// Note that Max is exclusive, so perhaps should be using a Begin/End convention.
struct ImGuiListClipperRange
{
int Min;

Loading…
Cancel
Save