From 2aecf378be3190920fd0e50aff6ccdc83ecfd7e9 Mon Sep 17 00:00:00 2001 From: Jim Mussared Date: Thu, 21 Jan 2021 10:09:02 +1100 Subject: [PATCH] tools/makemanifest.py: Add check that freeze path is a directory. Avoids accidentally writing freeze("path/to/file.py") and getting unexpected results. --- tools/makemanifest.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/makemanifest.py b/tools/makemanifest.py index 9ef0368260..c07a3a6c77 100644 --- a/tools/makemanifest.py +++ b/tools/makemanifest.py @@ -172,6 +172,8 @@ def mkdir(filename): def freeze_internal(kind, path, script, opt): path = convert_path(path) + if not os.path.isdir(path): + raise FreezeError("freeze path must be a directory") if script is None and kind == KIND_AS_STR: if any(f[0] == KIND_AS_STR for f in manifest_list): raise FreezeError("can only freeze one str directory")