tinygo

3908 Commits

99 Branches

41 Tags

26 MiB

Tree: 835e73237e

Commit Graph

Author	SHA1	Message	Date
dkegel-fastly	3d433fe9f1	Lint: lint and fix src/{os,reflect} (#4228 ) * lint: expand to src/{os,reflect}, fix or suppress what it found * internal/tools/tools.go: the tools idiom requires a build tag guard to avoid go test complaints	7 months ago
Dan Kegel	9d6e30701b	lint: add "make lint" target, run it from ci See https://github.com/tinygo-org/tinygo/issues/4225 Runs in both circleci and github, circleci is run on branch push, github is run on PR Revive builds so fast, don't bother installing it; saves us wondering which one we get Uses tools.go idiom to give control over linter versions to go.mod. Also pacifies linter re AppendToGlobal as a token first fix. TODO: gradually expand the number of directories that are linted, uncomment more entries in revive.toml, and fix or suppress the warnings lint finds. TODO: add linters "go vet" and staticcheck NOT TODO: don't add metalinters like golangci-lint that pull in lots of new of dependencies; we'd rather not clutter go.mod that much, let alone open ourselves up to the additional attack surface.	7 months ago

Author

SHA1

Message

Date

dkegel-fastly

3d433fe9f1

Lint: lint and fix src/{os,reflect} (#4228 )

* lint: expand to src/{os,reflect}, fix or suppress what it found

* internal/tools/tools.go: the tools idiom requires a build tag guard to avoid go test complaints

7 months ago

Dan Kegel

9d6e30701b

lint: add "make lint" target, run it from ci

See https://github.com/tinygo-org/tinygo/issues/4225

Runs in both circleci and github, circleci is run on branch push, github is run on PR

Revive builds so fast, don't bother installing it; saves us wondering which one we get

Uses tools.go idiom to give control over linter versions to go.mod.

Also pacifies linter re AppendToGlobal as a token first fix.

TODO: gradually expand the number of directories that are linted,
uncomment more entries in revive.toml, and fix or suppress the
warnings lint finds.

TODO: add linters "go vet" and staticcheck

NOT TODO: don't add metalinters like golangci-lint that pull in
lots of new of dependencies; we'd rather not clutter go.mod that
much, let alone open ourselves up to the additional attack surface.

7 months ago

2 Commits (835e73237e7413b5b71a5fe04f642b1768778c66)