From 8949904783c2fdda1b6c6cec99637cf6d5471359 Mon Sep 17 00:00:00 2001 From: Roberto Ierusalimschy Date: Tue, 6 Oct 2015 13:10:22 -0300 Subject: [PATCH] allow NULL string when length is zero in 'lua_pushlstring' and 'luaL_addlstring' --- lapi.c | 10 +++++----- lauxlib.c | 10 ++++++---- 2 files changed, 11 insertions(+), 9 deletions(-) diff --git a/lapi.c b/lapi.c index 63258055..072190bc 100644 --- a/lapi.c +++ b/lapi.c @@ -1,5 +1,5 @@ /* -** $Id: lapi.c,v 2.254 2015/08/25 18:50:37 roberto Exp roberto $ +** $Id: lapi.c,v 2.255 2015/09/09 13:45:50 roberto Exp roberto $ ** Lua API ** See Copyright Notice in lua.h */ @@ -472,15 +472,15 @@ LUA_API void lua_pushinteger (lua_State *L, lua_Integer n) { /* -** Pushes on the stack a string with given length. Even when 'len' == 0, -** 's' cannot be NULL due to later use of 'memcmp' and 'memcpy'. +** Pushes on the stack a string with given length. Avoid using 's' when +** 'len' == 0 (as 's' can be NULL in that case), due to later use of +** 'memcmp' and 'memcpy'. */ LUA_API const char *lua_pushlstring (lua_State *L, const char *s, size_t len) { TString *ts; lua_lock(L); luaC_checkGC(L); - api_check(L, s != NULL, "pointer cannot be NULL"); - ts = luaS_newlstr(L, s, len); + ts = (len == 0) ? luaS_new(L, "") : luaS_newlstr(L, s, len); setsvalue2s(L, L->top, ts); api_incr_top(L); lua_unlock(L); diff --git a/lauxlib.c b/lauxlib.c index 8985bf28..3702e375 100644 --- a/lauxlib.c +++ b/lauxlib.c @@ -1,5 +1,5 @@ /* -** $Id: lauxlib.c,v 1.281 2015/06/18 14:23:14 roberto Exp roberto $ +** $Id: lauxlib.c,v 1.282 2015/10/02 15:46:49 roberto Exp roberto $ ** Auxiliary functions for building Lua libraries ** See Copyright Notice in lua.h */ @@ -512,9 +512,11 @@ LUALIB_API char *luaL_prepbuffsize (luaL_Buffer *B, size_t sz) { LUALIB_API void luaL_addlstring (luaL_Buffer *B, const char *s, size_t l) { - char *b = luaL_prepbuffsize(B, l); - memcpy(b, s, l * sizeof(char)); - luaL_addsize(B, l); + if (l > 0) { /* avoid 'memcpy' when 's' can be NULL */ + char *b = luaL_prepbuffsize(B, l); + memcpy(b, s, l * sizeof(char)); + luaL_addsize(B, l); + } }