You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
43 lines
1.3 KiB
43 lines
1.3 KiB
2 years ago
|
From 8b3a95655b4391122e7b0315d8cc6f876caf8183 Mon Sep 17 00:00:00 2001
|
||
|
|
From: Daniel Kiper <daniel.kiper@oracle.com>
|
||
|
|
Date: Thu, 25 Feb 2021 18:35:01 +0100
|
||
|
|
Subject: [PATCH] util/grub-install: Fix NULL pointer dereferences
|
||
|
|
|
||
|
|
Two grub_device_open() calls does not have associated NULL checks
|
||
|
|
for returned values. Fix that and appease the Coverity.
|
||
|
|
|
||
|
|
Fixes: CID 314583
|
||
|
|
|
||
|
|
Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
|
||
|
|
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
|
||
|
|
Signed-off-by: Stefan Sørensen <stefan.sorensen@spectralink.com>
|
||
|
|
---
|
||
|
|
util/grub-install.c | 4 ++++
|
||
|
|
1 file changed, 4 insertions(+)
|
||
|
|
|
||
|
|
diff --git a/util/grub-install.c b/util/grub-install.c
|
||
|
|
index a82725f..367350f 100644
|
||
|
|
--- a/util/grub-install.c
|
||
|
|
+++ b/util/grub-install.c
|
||
|
|
@@ -1775,6 +1775,8 @@ main (int argc, char *argv[])
|
||
|
|
fill_core_services (core_services);
|
||
|
|
|
||
|
|
ins_dev = grub_device_open (install_drive);
|
||
|
|
+ if (ins_dev == NULL)
|
||
|
|
+ grub_util_error ("%s", grub_errmsg);
|
||
|
|
|
||
|
|
bless (ins_dev, core_services, 0);
|
||
|
|
|
||
|
|
@@ -1875,6 +1877,8 @@ main (int argc, char *argv[])
|
||
|
|
fill_core_services(core_services);
|
||
|
|
|
||
|
|
ins_dev = grub_device_open (install_drive);
|
||
|
|
+ if (ins_dev == NULL)
|
||
|
|
+ grub_util_error ("%s", grub_errmsg);
|
||
|
|
|
||
|
|
bless (ins_dev, boot_efi, 1);
|
||
|
|
if (!removable && update_nvram)
|
||
|
|
--
|
||
|
|
2.14.2
|
||
|
|
|